chore: remove unused properties and schemas#8378
Merged
jeremylong merged 2 commits intodependency-check:mainfrom Mar 21, 2026
Merged
chore: remove unused properties and schemas#8378jeremylong merged 2 commits intodependency-check:mainfrom
jeremylong merged 2 commits intodependency-check:mainfrom
Conversation
These are no longer used anywhere. Signed-off-by: Chad Wilson <[email protected]>
These were either removed a long time ago (CPE schema); or logic moved to open-vulnerability-clients so no longer should need to be maintained/distributed with ODC core. Signed-off-by: Chad Wilson <[email protected]>
boring-cyborg
Bot
added
core
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup of Dependency-Check configuration artifacts by removing unused default properties, marking corresponding settings keys as deprecated, and deleting legacy schema resources that are no longer referenced by ODC.
Changes:
- Remove unused default entries from
dependencycheck.properties(main + test resources). - Deprecate no-longer-used settings keys in
Settings.KEYSwithforRemovalmetadata. - Remove legacy NVD/CPE schema documents and a stale commented-out NVD generation block from
core/pom.xml.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| utils/src/test/resources/dependencycheck.properties | Drops unused proxy.disableSchemas and CPE defaults from utils test config. |
| utils/src/main/java/org/owasp/dependencycheck/utils/Settings.java | Deprecates unused settings constants (CPE, proxy schema disable, vfeed, downloader legacy keys). |
| core/src/test/resources/dependencycheck.properties | Drops unused proxy.disableSchemas and CPE defaults from core test config. |
| core/src/site/resources/images/readme.txt | Removes an obsolete readme file under site images. |
| core/src/main/resources/schema/external/nvd/nvd_cve_feed_json_1.1.schema | Deletes unused legacy NVD JSON schema resource. |
| core/src/main/resources/schema/external/nvd/cvss-v3.x.json | Deletes unused legacy CVSS v3 schema resource. |
| core/src/main/resources/schema/external/nvd/cvss-v2.0.json | Deletes unused legacy CVSS v2 schema resource. |
| core/src/main/resources/schema/external/nvd/CVE_JSON_4.0_min_1.1.schema | Deletes unused legacy CVE JSON schema resource. |
| core/src/main/resources/schema/external/cpe/cpe-dictionary_2.2.xsd | Deletes unused legacy CPE dictionary XSD resource. |
| core/src/main/resources/dependencycheck.properties | Drops unused proxy.disableSchemas and CPE defaults from main core config. |
| core/src/main/doc/schema/nvdcve/json/nvd_cve_feed_json_1.1.schema | Deletes unused legacy schema doc copy. |
| core/src/main/doc/schema/nvdcve/json/cvss-v3.x.json | Deletes unused legacy schema doc copy. |
| core/src/main/doc/schema/nvdcve/json/cvss-v2.0.json | Deletes unused legacy schema doc copy. |
| core/src/main/doc/schema/nvdcve/json/CVE_JSON_4.0_min_1.1.schema | Deletes unused legacy schema doc copy. |
| core/pom.xml | Removes a stale commented-out generate-nvd jsonschema2pojo execution block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Some minor tidies
Have test cases been added to cover the new functionality?
N/A