fix: #8356 narrow down VersionFilterAnalyzer scope to JAR files#8358
Merged
jeremylong merged 1 commit intodependency-check:mainfrom Mar 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns VersionFilterAnalyzer’s behavior with its JavaDoc and issue #8356 by limiting it to operate only on JAR files, using the file-type analyzer mechanism already used across the core analyzers.
Changes:
- Updated
VersionFilterAnalyzerto extendAbstractFileTypeAnalyzerand added a.jarFileFilterviaFileFilterBuilder. - Implemented
getFileFilter()andprepareFileTypeAnalyzer(...)to conform to theAbstractFileTypeAnalyzercontract. - Added a unit test ensuring only
.jarfiles are accepted by the analyzer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/src/main/java/org/owasp/dependencycheck/analyzer/VersionFilterAnalyzer.java | Converts analyzer to a file-type analyzer and restricts scope to .jar files via a FileFilter. |
| core/src/test/java/org/owasp/dependencycheck/analyzer/VersionFilterAnalyzerTest.java | Adds coverage asserting the analyzer only accepts JARs and rejects other extensions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
praise: thank you for taking the time to open the PR! I will perform a few additional checks to ensure this change is safe to integrate, this may take a bit of time, thank you for your patience! |
chadlwilson
approved these changes
Mar 21, 2026
jeremylong
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Related issues
fixes #8356
Have test cases been added to cover the new functionality?
yes