fix: improve configuration consistency (casing)#8355
Conversation
boring-cyborg
Bot
added
ant
chadlwilson
left a comment
chadlwilson
left a comment
There was a problem hiding this comment.
Things missed:
ant/src/test/resources/build.xmlstill referring to deprecated capitalizations. Should be updated.cli/src/main/resources/completion-for-dependency-check.shstill refers to deprecated capitalization, should not.- CLI: missed to correct
--disableRetireJS
|
suggestion(non-blocking): it may be scope creep and fitting more into an additional PR, this comment is more to raise the discussion. In order to assist the migration from the deprecated parameters to the new ones before the removal of the old parameters, could we consider adding warning logs in the form of:
? This may incentivize our users to switch prior the major version and ease their migration. I am considering doing something similar for the ossIndex url, so it could fit in an additional change. If we prefer to add this change in a following PR, I can create a task. |
|
@nhumblot I fully support your proposal. |
|
Thanks for the feedback - I'll try to incorporate this over the weekend. |
chadlwilson
left a comment
chadlwilson
left a comment
There was a problem hiding this comment.
LGTM, thanks @jeremylong !
4 participants
Description of Change
Used
ampto check if we had any inconsistencies between configuration names and documentation. When incorrectly cased configuration items were found, the old field/property/etc. was deprecated, and the correctly cased variant was added.