test: Make tests locale independent#8328
Merged
jeremylong merged 3 commits intomainfrom Feb 28, 2026
Merged
Conversation
boring-cyborg
Bot
added
core
chadlwilson
approved these changes
Feb 27, 2026
Collaborator
|
Makes it a bit harder to understand the nature of the tests, but I guess I understand why you want to change this. Since ODC is not localized software, If it was easier to get IDEs to pick up settings from maven surefire config I'd normally have preferred to just force the locale during tests (or use a system properties test extension to enforce a locale for duration of the test) but I think either of those will probably be a bit of a pain. |
jeremylong
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This change proposes to improve assertions to make them locale independent. The updated tests are failing on a French locale system.
Related issues
None
Have test cases been added to cover the new functionality?
no new test as no functionality is added