fix: Correct published/hosted suppressions namespace header and indent#8258
fix: Correct published/hosted suppressions namespace header and indent#8258nhumblot merged 1 commit intodependency-check:mainfrom
Conversation
…ssions (and HTML template) Signed-off-by: Chad Wilson <[email protected]>
chadlwilson
changed the title
|
If @jeremylong or @nhumblot are around a quick review and/or merge would be appreciated, since the hosted suppressions are currently broken (by me) 😬😬 |
There was a problem hiding this comment.
Hi @chadlwilson
Thank you very much for preparing this PR! I just checked from my phone. Looks ok to me, I'm going to merge. If things continue to not work, I can look at it in a few hours
|
TODO (action @nhumblot ): create a task to see how we can improve our validation in the CI |
|
Yeah … xml inside JavaScript inside yaml isn’t exactly the best DevEx 😄 |
Assuming GitHub script is the way forward, probably best to at least source control all of the GitHub script content separately as JS files: https://github.com/actions/github-script?tab=readme-ov-file#run-a-separate-file That way you avoid the yaml indent problems; can get IDE support for the JS (and probably XMl-in-a-string) as well as theoretically write unit tests for the GitHub script, with some mocking/stubbing, and even factor out the XML pieces into JS templates or something simple. I can probably submit a PR to at least get us going with the source controlling. |
2 participants
Description of Change
URGENT: #8254 had a missing trailing quote in the syntax for creating the published suppressions so the current published file is not well formed XML and will be failing. Gulp.
I was deliberately testing it via #8257 (it's a real FP) to make sure it was OK, and noticed I'd broken it.
This PR should fix it (and tweak the indents slightly; as I hadn't noticed an
elseblock in theapprovalsworkflow)See https://dependency-check.github.io/DependencyCheck/suppressions/publishedSuppressions.xml
Generated suppressions - ✅ 8750da5
Published suppressions - ❌ 593b647
Related issues
Have test cases been added to cover the new functionality?
no