fix: Correct Archive Analyzer behaviour on certain tgz archives#7986
Merged
jeremylong merged 1 commit intodependency-check:mainfrom Sep 30, 2025
Merged
Conversation
This reverts commit 4c33e0a - fixes dependency-check#7985 Signed-off-by: Chad Wilson <[email protected]>
marcelstoer
approved these changes
Sep 29, 2025
Collaborator
marcelstoer
left a comment
marcelstoer
left a comment
There was a problem hiding this comment.
LGTM
I didn't find any indication in the commons-compress project as to when they plan to release the five fixes that landed on master since 1.28.0, pity.
Collaborator
Author
|
Many of those smaller library Apache projects are basically maintained by the same solo maintainer, and they still do their (somewhat old school now) practice of voting for releases on mailing lists and stuff, I think. |
jeremylong
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
commons-compress 1.28.0 seems to have issues with changing default behaviour on some archives: https://issues.apache.org/jira/browse/COMPRESS-705
Since the release cadence for Apache Commons stuff is a bit unpredictable, even in the face of a regression, we should probably just roll this back for now?
This reverts commit 4c33e0a
Related issues
Have test cases been added to cover the new functionality?
no