Skip to content

fix: improve error message on improperly configured serverId credentials in settings.xml#7313

Merged
jeremylong merged 2 commits intomainfrom
fix/issue-7309
Jan 15, 2025
Merged

fix: improve error message on improperly configured serverId credentials in settings.xml#7313
jeremylong merged 2 commits intomainfrom
fix/issue-7309

Conversation

@aikebah
Copy link
Copy Markdown
Collaborator

@aikebah aikebah commented Jan 13, 2025

Description of Change

Improve the error-message to clarify that basic auth configuration was encountered when only bearer auth configuration is expected/supported and vice versa.

Related issues

fixes #7309 by providing a clearer error-message.

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg Bot added the maven changes to the maven plugin label Jan 13, 2025
@aikebah aikebah added this to the 12.0.1 milestone Jan 13, 2025
To address the remark in jeremylong/DependencyCheck#7309 (comment) on inability to configure password-only setttings.xml serverId entries on certain CI systems.
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit c1f5d16 into main Jan 15, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 15, 2025
@aikebah aikebah deleted the fix/issue-7309 branch March 2, 2025 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maven changes to the maven plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic type serverId encountered in nvd, but userKey or passwordKey is null

2 participants