Skip to content

fix: Correct nonProxyHosts support when no sys properties set#7306

Merged
jeremylong merged 1 commit intodependency-check:mainfrom
chadlwilson:fix-non-proxy-hosts
Jan 13, 2025
Merged

fix: Correct nonProxyHosts support when no sys properties set#7306
jeremylong merged 1 commit intodependency-check:mainfrom
chadlwilson:fix-non-proxy-hosts

Conversation

@chadlwilson
Copy link
Copy Markdown
Collaborator

Description of Change

Makes the checking/merging of system properties with Maven config more robust to nulls/whitespace.

Related issues

fixes #7304

Have test cases been added to cover the new functionality?

N/A

@boring-cyborg boring-cyborg Bot added the maven changes to the maven plugin label Jan 13, 2025
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit e9087d5 into dependency-check:main Jan 13, 2025
@jeremylong jeremylong added this to the 12.0.1 milestone Jan 13, 2025
@chadlwilson chadlwilson deleted the fix-non-proxy-hosts branch January 13, 2025 11:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maven changes to the maven plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

owasp 11.1.0>12.0.0 update: Cannot invoke "String.split(String)" because "existingNonProxyHosts" is null

2 participants