Skip to content

feat: Use Maven settings decryption API for decrypting secrets from settings.xml#7284

Merged
jeremylong merged 1 commit intomainfrom
feat/issue-7279
Jan 4, 2025
Merged

feat: Use Maven settings decryption API for decrypting secrets from settings.xml#7284
jeremylong merged 1 commit intomainfrom
feat/issue-7279

Conversation

@aikebah
Copy link
Copy Markdown
Collaborator

@aikebah aikebah commented Jan 2, 2025

Description of Change

Replace the use of the plexus-security library, that is considered part of maven's internals for the official maven API for decrypting encrypted secrets from settings.xml.

Related issues

fixes #7279

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg Bot added the maven changes to the maven plugin label Jan 2, 2025
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong added this to the 12.0.0 milestone Jan 4, 2025
@jeremylong jeremylong merged commit 505ddff into main Jan 4, 2025
@jeremylong jeremylong deleted the feat/issue-7279 branch January 4, 2025 12:57
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maven changes to the maven plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maven 4.x forward compatibility broken for settings.xml encrypted secrets

2 participants