Skip to content

fix: Tranform into UTC the last modified date from database#7222

Merged
jeremylong merged 4 commits intodependency-check:mainfrom
ftiercelin:main
Dec 4, 2024
Merged

fix: Tranform into UTC the last modified date from database#7222
jeremylong merged 4 commits intodependency-check:mainfrom
ftiercelin:main

Conversation

@ftiercelin
Copy link
Copy Markdown
Contributor

@ftiercelin ftiercelin commented Dec 4, 2024

Fixes Issue

Description of Change

  • turn into UTC the last modified date retrieved from database
  • change minusDays(-120) into plusDays(120) to enhance code legibility

Have test cases been added to cover the new functionality?

n/a not a new functionality

…red by NvdCveClientBuilder#withLastModifiedFilter

replace minusDays(-120) with plusDays(120) when calculating end date for increased legibility
@boring-cyborg boring-cyborg Bot added the core changes to core label Dec 4, 2024
@ftiercelin ftiercelin changed the title Tranform into UTC the last modified date from database fix: Tranform into UTC the last modified date from database Dec 4, 2024
@jeremylong jeremylong added this to the 12.0.0 milestone Dec 4, 2024
@jeremylong
Copy link
Copy Markdown
Collaborator

Thank you for figuring this out! I really appreciate the PR!

jeremylong
jeremylong previously approved these changes Dec 4, 2024
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread core/src/main/java/org/owasp/dependencycheck/data/update/NvdApiDataSource.java Outdated
@jeremylong jeremylong merged commit 97c3cee into dependency-check:main Dec 4, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants