fix: Gracefully handle CVEs with bad configuration nodes missing CPE match expressions#7125
Merged
jeremylong merged 1 commit intodependency-check:mainfrom Nov 4, 2024
Conversation
…match expressions Signed-off-by: Chad Wilson <[email protected]>
Collaborator
|
Thanks for the PR - I would have merged this sooner but I've been on vacation/holiday. I have some downtime on the train to Brussels so thought I'd get a little work on ODC done. I will get this released once I get back home in a couple days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The NVD API sometimes returns nodes (
OR,ANDetc) forconfigurations that are missing the requiredcpeMatcharray implied by the schema at https://csrc.nist.gov/schema/nvd/api/2.0/cve_api_json_2.0.schemaWhile the data is bad, it'd probably be better for ODC to be robust to handle these when checking for matches. The change ignores attempting to match configurations which have no
cpeMatcharray (treats the same as an empty array).Have test cases been added to cover the new functionality?
yes