false positives for jetcd libraries#7117
false positives for jetcd libraries#7117jeremylong merged 1 commit intodependency-check:generatedSuppressionsfrom
Conversation
|
I see that some checks failed in codacy but I cannot see the details. Please advise. |
b7ffd13 to
1d4336f
Compare
|
I've missed the <suppress>
<notes><![CDATA[
FP per issue #7123
]]></notes>
<packageUrl regex="true">^pkg:maven/io\.etcd/jetcd-[a-z]*@.*$</packageUrl>
<cpe>cpe:/a:etcd:etcd</cpe>
<cpe>cpe:/a:redhat:etcd</cpe>
</suppress>❓ |
|
Yeah, if you look at the rest of the suppressions file you'll note that there a number of suppressions like that. |
* they were treated as etcd server * jetcd-grpc was treated as io.grpc library
|
Ok, so from my point of view, the PR is ready 😉 |
|
Super busy - but I expect to release the next version within a few days. |
|
regarding the failed check - I really dislike how frequently that check fails. It really hasn't been valuable and I'm considering removing the codacy check from the workflow soon. |
Fixes Issue #7123
Description of Change
Have test cases been added to cover the new functionality?
no