fix: do not set legacy proxy from maven or env (#7072)#7074
Merged
aikebah merged 1 commit intodependency-check:mainfrom Oct 23, 2024
Merged
fix: do not set legacy proxy from maven or env (#7072)#7074aikebah merged 1 commit intodependency-check:mainfrom
aikebah merged 1 commit intodependency-check:mainfrom
Conversation
aikebah
requested changes
Oct 23, 2024
dependency-check#7074) The Apache HTTPClient based downloader supports http(s).proxy* properties, so we do not need to use legacy logic. In legacy mode http.nonProxyHosts is not honored, so setting both leads to issues due to missing proxy selectors. Omit populating legacy properties resolves this issue. In addition, we have to move the password decryption from Maven settings up, so it actually works. Signed-off-by: Stefan Kalscheuer <[email protected]>
stklcode
force-pushed
the
fix/7072-proxy
branch
from
196b029 to
e6f022b
Compare
aikebah
approved these changes
Oct 23, 2024
Collaborator
|
@stklcode Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
#7072
Description of Change
The Apache HTTPClient based downloader supports http(s).proxy* properties, so we do not need to use legacy logic. In legeacy mode http.nonProxyHosts is not honored, so setting both leads to issues due to missing proxy selectors.
Omit populating legacy properties resolves this issue. In addition we have to move the password decryption from Maven settings up, so it actually works.
Have test cases been added to cover the new functionality?
no