fix: Fixup parameter sequence for Dowloader credentials#7033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
While working on (still work in progress) also using HTTPClient for access to Nexus I encountered an authentication issue due to an improper sequence of arguments for some of the tryAdd...Credentials methods that was overlooked in the changes of PR #6949. Two occurrences had the arguments accidentally coded as the sequence urlkey, userkey, passwordkey instead of the userkey, urlkey, passwordkey required by the
addUserPasswordCredsmethodHave test cases been added to cover the new functionality?
no