Skip to content

chore: checkstyle configuration and suggested updates#7003

Merged
jeremylong merged 6 commits intomainfrom
scratch/checkstyle
Oct 3, 2024
Merged

chore: checkstyle configuration and suggested updates#7003
jeremylong merged 6 commits intomainfrom
scratch/checkstyle

Conversation

@jeremylong
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong commented Oct 1, 2024

  • fixes several checkstyle warnings
  • add checkstyle back into PR workflow
  • add spotbugs back into the PR workflow

@boring-cyborg boring-cyborg Bot added cli changes to the cli core changes to core maven changes to the maven plugin labels Oct 1, 2024
@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jeremylong jeremylong merged commit 76051ca into main Oct 3, 2024
@jeremylong jeremylong deleted the scratch/checkstyle branch October 3, 2024 11:18
@jeremylong jeremylong added this to the 11.0.0 milestone Oct 3, 2024
Comment on lines -92 to +98
* Example values:
* - binary "https://dl.google.com/geosdk/GoogleMaps.json" "7.2.0"
* - git "https://gitlab.matrix.org/matrix-org/olm.git" "3.2.16"
* - github "alinradut/SwiftEntryKit" "95f4a08f41ddcf2c02e2b22789038774c8c94df5""
* - github "CocoaLumberjack/CocoaLumberjack" "3.8.5"
* - github "realm/realm-swift" "v10.44.0"
* Example values: - binary "https://dl.google.com/geosdk/GoogleMaps.json"
* "7.2.0" - git "https://gitlab.matrix.org/matrix-org/olm.git" "3.2.16" -
* github "alinradut/SwiftEntryKit"
* "95f4a08f41ddcf2c02e2b22789038774c8c94df5"" - github
* "CocoaLumberjack/CocoaLumberjack" "3.8.5" - github "realm/realm-swift"
* "v10.44.0"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremylong Might be good to still post-merge review and correct occurrences like this in the delta that transformed 'nicely coded, but horribly rendered by Javadoc' to 'horribly coded, and horribly rendered by Javadoc' javadoc comments.
They should've been converted to proper HTML <ul> + <li> to be rendered as intended by the original written code rather than reformatted to have the bulleted items all rendered as 'standard javadoc text paragraph'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love autoformatting sometimes... Thanks for pointing this out.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cli changes to the cli core changes to core maven changes to the maven plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants