Skip to content

chore(docs): Fixup javadoc warnings#6995

Merged
jeremylong merged 4 commits intomainfrom
scratch/fixup-javadoc
Sep 29, 2024
Merged

chore(docs): Fixup javadoc warnings#6995
jeremylong merged 4 commits intomainfrom
scratch/fixup-javadoc

Conversation

@aikebah
Copy link
Copy Markdown
Collaborator

@aikebah aikebah commented Sep 29, 2024

Description of Change

While looking at build output I spotted a series of Javadoc warnings and errors.

The changes fixup javadoc warnings on missing documentation parts and invalid HTML5 constructs. Partly by fixing the documentation and partly by removing unneeded (and undocumented) throws-clauses for exceptions that are never thrown by the method body.
Also includes a configuration fix for the javadoc plugin to make Javadoc aware of the @implNote javadoc tag that is standardized in Java 8, but not yet by default supported by the Javadoc tool, so that it requires explicit activation as a custom tag.

Have test cases been added to cover the new functionality?

N/A

@boring-cyborg boring-cyborg Bot added core changes to core maven changes to the maven plugin utils changes to utils labels Sep 29, 2024
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong
Copy link
Copy Markdown
Collaborator

I also plan on going through the checkstyle before doing the 11.0 release. I'll try to do this tomorrow morning.

@jeremylong jeremylong merged commit b77009e into main Sep 29, 2024
@jeremylong jeremylong deleted the scratch/fixup-javadoc branch September 29, 2024 23:42
@jeremylong jeremylong added this to the 11.0.0 milestone Oct 3, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core maven changes to the maven plugin utils changes to utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants