build: Update Checkstyle configuration and Suppression DTD references#6951
Merged
jeremylong merged 1 commit intomainfrom Sep 10, 2024
Merged
build: Update Checkstyle configuration and Suppression DTD references#6951jeremylong merged 1 commit intomainfrom
jeremylong merged 1 commit intomainfrom
Conversation
…t version and location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Discovered that the DTD locations were outdated http locations. Checkstyle project has them now published on checkstyle.org served with https. Also found that there have been some newer suppressions DTDs, so while updating the location and public ID to comply with current Checkstyle documentation also updated the suppressions file to point to the current version (which has been modified to allow more flexible filtering:
filesis no longer required and at least one ofchecks(previously required),message(new) orid(new) is required to be present as the item to filter)Have test cases been added to cover the new functionality?
N/A