build: Remove the animal-sniffer, propagate java version to plugin-archetype#6950
Merged
jeremylong merged 1 commit intomainfrom Sep 8, 2024
Merged
build: Remove the animal-sniffer, propagate java version to plugin-archetype#6950jeremylong merged 1 commit intomainfrom
jeremylong merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
As a result of a first PR that was using the Java 11 API I found out that the Java 11 migration PR had missed the removal of the no longer needed animal-sniffer plugin.
Now that we've upgraded to target Java 11 as the minimal baseline and use the javac
--releaseoption (triggered by themaven.compiler.releaseproperty) the compiler already takes care of ensuring compliance with the Java public API of the target version.Also added population of the
maven.compiler.releaseproperty to the pom that gets generated from the dependency-check-plugin archetype.Have test cases been added to cover the new functionality?
N/A