fix: improve regex#6917
Merged
jeremylong merged 1 commit intomainfrom Aug 26, 2024
Merged
Conversation
aikebah
approved these changes
Aug 25, 2024
Collaborator
aikebah
left a comment
aikebah
left a comment
There was a problem hiding this comment.
LGTM
Though 100 digits feels a excessive for a version number, it would do the job of ReDOS prevention and still allow any reasonable previously matching version number to still match the RegEx.
Collaborator
Author
|
I agree, 100 is excessive - but I've been burnt in the past by thinking there is no way we would see data of X characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/jeremylong/DependencyCheck/security/code-scanning/14
Improves the regex so it does not use
+and instead cap the version number at 100 digits.