Skip to content

fix: change request if lockfile is file v3#6690

Merged
jeremylong merged 1 commit intodependency-check:mainfrom
spielerf:add_lockfilev3_support
May 28, 2024
Merged

fix: change request if lockfile is file v3#6690
jeremylong merged 1 commit intodependency-check:mainfrom
spielerf:add_lockfilev3_support

Conversation

@spielerf
Copy link
Copy Markdown
Contributor

Fixes Issue

#6437

Description of Change

changed request to npm, when package-lock.json used in V3. The "dependencies" block seems to be ignored from npm api, so changed block back to "requires" like in V2.

Have test cases been added to cover the new functionality?

No

@boring-cyborg boring-cyborg Bot added the core changes to core label May 27, 2024
@spielerf spielerf changed the title change request if lockfile is file v3 fix: change request if lockfile is file v3 May 27, 2024
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants