fix: skip pyproject.toml unless it contains tool.poetry before ensuring lockfiles#6681
Merged
jeremylong merged 1 commit intodependency-check:mainfrom May 25, 2024
Merged
Conversation
jeremylong
approved these changes
May 23, 2024
Collaborator
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #5971
Description of Change
Even after this PR was merged I am encountering the issue found in #5971. When scanning a dependency with a
pyproject.tomlfile that does not use Poetry, an exception is still thrown.The changes in this PR check if "tool.poetry" exists in
pyproject.tomlbefore checking that a lockfile (poetry.lock, requirements.txt) exist so that we can return gracefully if Poetry is not present instead of throwing an exception.Have test cases been added to cover the new functionality?
yes, but am open to adding more if needed