Skip to content

fix: Ensure valid JSON output for gitlab report#6630

Merged
jeremylong merged 1 commit intomainfrom
issue-6593
Apr 29, 2024
Merged

fix: Ensure valid JSON output for gitlab report#6630
jeremylong merged 1 commit intomainfrom
issue-6593

Conversation

@aikebah
Copy link
Copy Markdown
Collaborator

@aikebah aikebah commented Apr 28, 2024

Fixes Issue #6593

Description of Change

Add a different guard for adding a comma, so that in case of nameless dependencies no trailing comma is added.

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg Bot added the core changes to core label Apr 28, 2024
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong added this to the 9.2.0 milestone Apr 29, 2024
@jeremylong jeremylong merged commit d464dee into main Apr 29, 2024
@jeremylong jeremylong deleted the issue-6593 branch April 29, 2024 13:49
@jeremylong
Copy link
Copy Markdown
Collaborator

I will try and release 9.2 soon.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants