Skip to content

feat: Support Package.swift version 3 Specification#6578

Merged
jeremylong merged 2 commits intodependency-check:mainfrom
tx2:main
Apr 13, 2024
Merged

feat: Support Package.swift version 3 Specification#6578
jeremylong merged 2 commits intodependency-check:mainfrom
tx2:main

Conversation

@tx2
Copy link
Copy Markdown
Contributor

@tx2 tx2 commented Apr 11, 2024

Fixes Issue

Description of Change

With the recent release of Swift 5.10 there is a new specification for the Package.resolved dependencies file. This PR aims to support the new spec on the analyzer since the structure of the file has changed.

Have test cases been added to cover the new functionality?

yes

@boring-cyborg boring-cyborg Bot added core changes to core tests test cases labels Apr 11, 2024
@tx2 tx2 changed the title Support Package.swift version 3 Specification feat: Support Package.swift version 3 Specification Apr 11, 2024
Copy link
Copy Markdown
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR

@aikebah
Copy link
Copy Markdown
Collaborator

aikebah commented Apr 12, 2024

@jeremylong Do you see a need for a 9.1.1 bugfix release? Or should we bump milestone to 9.2.0 and merge this PR for next release?

Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit f2c1d0a into dependency-check:main Apr 13, 2024
@jeremylong jeremylong added this to the 9.1.1 milestone Apr 13, 2024
@jeremylong
Copy link
Copy Markdown
Collaborator

I'm planning on just bumping the entire milestone to 9.2.0 - and just not releasing 9.1.1.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core tests test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants