Skip to content

feat: Add v2 support for maven_install.json#6528

Merged
jeremylong merged 2 commits intodependency-check:mainfrom
nutshelllabs:main
Mar 20, 2024
Merged

feat: Add v2 support for maven_install.json#6528
jeremylong merged 2 commits intodependency-check:mainfrom
nutshelllabs:main

Conversation

@efabens
Copy link
Copy Markdown
Contributor

@efabens efabens commented Mar 18, 2024

Fixes Issue

jeremylong/DependencyCheck#6527

Description of Change

  • Implement v2 schema support for maven_install.json.
  • Maintains backwards compatibility with v0.1.0

Have test cases been added to cover the new functionality?

yes
Added a v2 testfile from Bazel's mainline root directory. It is large (but smaller than the ones in the repos I am currently working with), I would rather not manually construct a smaller one but can if there is a strong preference.

efabens and others added 2 commits March 18, 2024 15:47
- Implement v2 schema support for `maven_install.json`.
- Maintains backwards compatibility with v0.1.0
@boring-cyborg boring-cyborg Bot added core changes to core tests test cases labels Mar 18, 2024
@efabens efabens changed the title Add v2 support for maven_install.json feat: Add v2 support for maven_install.json Mar 18, 2024
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit f60c867 into dependency-check:main Mar 20, 2024
@jeremylong jeremylong added this to the 9.1.0 milestone Mar 20, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core tests test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants