fix: NoSuchMethodError closeQuietly(java.io.Closeable[])#6377
Merged
jeremylong merged 1 commit intomainfrom Jan 14, 2024
Merged
fix: NoSuchMethodError closeQuietly(java.io.Closeable[])#6377jeremylong merged 1 commit intomainfrom
jeremylong merged 1 commit intomainfrom
Conversation
| try { | ||
| jsonParser.close(); | ||
| } catch (IOException ex) { | ||
| //ignore |
There was a problem hiding this comment.
Should these be at least logged at an appropriate level rather than silenced completely?
Collaborator
Author
There was a problem hiding this comment.
if the close fails - there would be other esceptions that would be logged. The other exceptions would be more meaningful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #6373