fix: rework fix for closing input streams on errors correctly#6338
Merged
jeremylong merged 1 commit intodependency-check:mainfrom Dec 23, 2023
Merged
Conversation
jeremylong
approved these changes
Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixup for #6326, 006684b
Description of Change
I visited my change, and have noticed I missed my actual goal at the end. 🙄 My final and already merged change does not break something, but my initial intention of closing everything was not fulfilled. Sorry for the mess..
🎄 Happy holidays.
Have test cases been added to cover the new functionality?
no