fix: reduce chance NVD API block updates due to rate limit#6333
Merged
jeremylong merged 1 commit intomainfrom Dec 21, 2023
Merged
fix: reduce chance NVD API block updates due to rate limit#6333jeremylong merged 1 commit intomainfrom
jeremylong merged 1 commit intomainfrom
Conversation
- increase default delay from 2000 to 3500 - resolves #6195
boring-cyborg
Bot
added
ant
VaeterchenFrost
approved these changes
Dec 20, 2023
Chr1stian
approved these changes
Dec 21, 2023
Chr1stian
left a comment
Chr1stian
left a comment
There was a problem hiding this comment.
Worked for us! (maybe add some more to the logs to inform users if they encounter issues that might be resolved by increasing the delay?)
Collaborator
Author
|
@Chr1stian the improved logging was added with jeremylong/DependencyCheck#6324. Glad increasing the delay resolved the problem you were having. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my system, with an API key this change adds about 30 seconds to a full update.