Skip to content

fix: mask nvd.api.key in logs#6307

Merged
jeremylong merged 1 commit intomainfrom
scratch/mask-key
Dec 15, 2023
Merged

fix: mask nvd.api.key in logs#6307
jeremylong merged 1 commit intomainfrom
scratch/mask-key

Conversation

@jeremylong
Copy link
Copy Markdown
Collaborator

@boring-cyborg boring-cyborg Bot added core changes to core tests test cases utils changes to utils labels Dec 15, 2023
@jeremylong jeremylong merged commit f7ccabb into main Dec 15, 2023
@jeremylong jeremylong deleted the scratch/mask-key branch December 15, 2023 11:38
@hott-box
Copy link
Copy Markdown

GHSA-qqhq-8r2c-c3f5 isn't resolved; 9.0.6 still logs nvdApiKey; see the advisory for more details.

@jeremylong
Copy link
Copy Markdown
Collaborator Author

@hott-box the documentation is being updated indicating that if specific configuration options are used maven debug logging could expose them. See jeremylong/DependencyCheck#6315.

This is how maven works - the configuration is presented in the debug output.

@jeremylong
Copy link
Copy Markdown
Collaborator Author

@hott-box if you have put the credential clear text in the build file - it is already exposed. Allowing maven to write this back to the debug logging is not making it any less exposed.

@zodac-personal
Copy link
Copy Markdown

@jeremylong , FYI, while I don't really see this as a huge issue myself, I am passing in the API credential through environment variables, so it is possible for it to be exposed only through the debug logs.

@jeremylong
Copy link
Copy Markdown
Collaborator Author

@zodac it all depends on how you are passing it in via env variable - and whether or not you are using a CI env that will mask the secrets printed to the console. GH Secrets as an ENV variable would likely mask the possible exposure; the same with Jenkins withCredential.

@jeremylong
Copy link
Copy Markdown
Collaborator Author

and I 100% agree - this is not a very impactful issue if the secret exposure occurs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core tests test cases utils changes to utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants