Skip to content

fix: Gitlab report broken after NVD api changes#6166

Merged
jeremylong merged 2 commits intodependency-check:mainfrom
weyhmueller:fix/gitlab-report-broken
Nov 29, 2023
Merged

fix: Gitlab report broken after NVD api changes#6166
jeremylong merged 2 commits intodependency-check:mainfrom
weyhmueller:fix/gitlab-report-broken

Conversation

@weyhmueller
Copy link
Copy Markdown
Contributor

Fixes Issue #6165

Description of Change

This PR restores the functionality from PR #5920.

Have test cases been added to cover the new functionality?

no, this PR provides no new functionality

Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong
Copy link
Copy Markdown
Collaborator

Sorry that I missed that instance - I tried to find all instances of $vulnerability.cvssV3.getBaseSeverity() to add the getData() and looks like I missed this one. This update will be in the next release.

@jeremylong jeremylong added this to the 9.0.2 milestone Nov 28, 2023
@jeremylong jeremylong merged commit 355736f into dependency-check:main Nov 29, 2023
@weyhmueller weyhmueller deleted the fix/gitlab-report-broken branch December 1, 2023 18:23
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants