fix: Do not filter out evidences added by hints#5900
Merged
jeremylong merged 3 commits intomainfrom Oct 5, 2023
Merged
Conversation
as #534 is properly resolved since the change to JSON NVD feeds as per #646 jeremylong/DependencyCheck#646 (comment)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #5894
Description of Change
Add a marker to the evidences to indicate an evidence came from a hints file (as the evidence source is fully user-controllable the source is not usable to detect hint-origin) and avoid removal of those hints when filtering 'inaccurate' evidences in the VersionFilterAnalyzer.
Also removes the now obsolete hint for a historical Hibernate-validator false-negative that is already properly resolved since the switch to JSON datafeeds.
Have test cases been added to cover the new functionality?
no