Skip to content

feat: Add support for Nexus v3 to NexusAnalyzer#5849

Merged
jeremylong merged 4 commits intomainfrom
nexusv3-support
Aug 19, 2023
Merged

feat: Add support for Nexus v3 to NexusAnalyzer#5849
jeremylong merged 4 commits intomainfrom
nexusv3-support

Conversation

@aikebah
Copy link
Copy Markdown
Collaborator

@aikebah aikebah commented Jul 31, 2023

Fixes Issue #5319

Description of Change

Implement support for Nexus V3 REST API to search for artifact by SHA-1 hash in addition to the current Nexus V2 API support.

The NexusAnalyzer now attempts to use Nexus v2 API if the standard Nexus v2 API prefix (service/local) is found in the Nexus Analyzer URL. Otherwise it will attempt to use the Nexus v3 API.

Have test cases been added to cover the new functionality?

Existing test-case for NexusV2 has been cloned into a copy for V3, including the @Ignore of all testcases by default. Locally they have been used to test against private Nexus Repository OSS V2 and Nexus Repository OSS V3 instances to validate that both the Nexus V2 and Nexus V3 implementations are passing the tests.

@boring-cyborg boring-cyborg Bot added core changes to core tests test cases labels Jul 31, 2023
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit e685b80 into main Aug 19, 2023
@jeremylong jeremylong deleted the nexusv3-support branch August 19, 2023 11:58
@jeremylong jeremylong added this to the 8.4.0 milestone Aug 19, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core tests test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants