Skip to content

fix: #5671 out of memory error#5789

Merged
aikebah merged 3 commits intomainfrom
5671-out-of-memory-error
Jun 22, 2023
Merged

fix: #5671 out of memory error#5789
aikebah merged 3 commits intomainfrom
5671-out-of-memory-error

Conversation

@nhumblot
Copy link
Copy Markdown
Collaborator

@nhumblot nhumblot commented Jun 21, 2023

Fixes Issue

Fix #5671

Description of Change

This change add a return statement as soon as a self referencing variables loop is identified to prevent an infinite loop in the code, leading to an OutOfMemoryError.

Have test cases been added to cover the new functionality?

yes

@boring-cyborg boring-cyborg Bot added core changes to core tests test cases labels Jun 21, 2023
@nhumblot nhumblot changed the title 5671 out of memory error fix: #5671 out of memory error Jun 21, 2023
…an infinite loop leading to an OutOfMemoryError
Copy link
Copy Markdown
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aikebah
Copy link
Copy Markdown
Collaborator

aikebah commented Jun 22, 2023

Not yet merging to give @jeremylong a chance to get the 8.3.1 gradle plugin out before merging in new fixes

@aikebah aikebah added this to the 8.3.2 milestone Jun 22, 2023
@jeremylong
Copy link
Copy Markdown
Collaborator

Gradle plugin was published this morning.

@aikebah aikebah merged commit 82ea742 into main Jun 22, 2023
@jeremylong jeremylong deleted the 5671-out-of-memory-error branch December 5, 2023 11:43
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core tests test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

java.lang.OutOfMemoryError: Java heap space on python project analysis

3 participants