feat: enable local proxy configuration in maven plugin configuration#5696
Merged
jeremylong merged 5 commits intodependency-check:mainfrom May 16, 2023
mischa-n:provide_full_proxy_configuration_in_plugin_configuration
Merged
feat: enable local proxy configuration in maven plugin configuration#5696jeremylong merged 5 commits intodependency-check:mainfrom mischa-n:provide_full_proxy_configuration_in_plugin_configuration
jeremylong merged 5 commits intodependency-check:mainfrom
mischa-n:provide_full_proxy_configuration_in_plugin_configuration
Conversation
jeremylong
requested changes
May 7, 2023
Collaborator
jeremylong
left a comment
There was a problem hiding this comment.
Any place we are accepting credentials we should allow this to be retrieved from the settings.xml.
Contributor
Author
|
@jeremylong : is there anything else I can do here to get the PR accepted? |
jeremylong
approved these changes
May 16, 2023
Collaborator
|
Sorry about the delay - thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to Issue #5040
Description of Change
CICD-SEC-03 recommends:
We have solved (2), trust our developers, they trust the developers of the third party libraries in use, and those trust the developers of dependent fourth party libraries ...
Nevertheless, we would like to go one step further and completely disable access to the Internet in our CI/CD pipeline.
Therefore, we need to configure a proxy for the dependency-check-maven plugin.
Currently, you can define a proxy to use in the dependency-check-maven plugin via the Maven settings or the system property
http.proxyHost.However, in both cases, the configured proxy is used not only for loading data for analysis, but potentially for dependency resolution as well:
With the proposed change, a local proxy can be configured for the dependency-check-maven plugin, which is then used exclusively for loading the analysis data:
Have test cases been added to cover the new functionality?
no