Skip to content

feat: add LibmanAnalyzer#5652

Merged
jeremylong merged 7 commits intodependency-check:mainfrom
ArjenKorevaar:feature/LibmanAnalyzer
Apr 19, 2023
Merged

feat: add LibmanAnalyzer#5652
jeremylong merged 7 commits intodependency-check:mainfrom
ArjenKorevaar:feature/LibmanAnalyzer

Conversation

@ArjenKorevaar
Copy link
Copy Markdown
Contributor

@ArjenKorevaar ArjenKorevaar commented Apr 5, 2023

Fixes Issue #1567

Description of Change

Adds an analyzer for Libman package references from libman.json files.

Have test cases been added to cover the new functionality?

Yes

@boring-cyborg boring-cyborg Bot added ant changes to ant core changes to core documentation site documentation maven changes to the maven plugin tests test cases utils changes to utils labels Apr 5, 2023
@ArjenKorevaar ArjenKorevaar changed the title Add LibmanAnalyzer feat: add LibmanAnalyzer Apr 5, 2023
@jeremylong
Copy link
Copy Markdown
Collaborator

Thanks for the PR! I've been on vacation - I will review this early next week.

@ArjenKorevaar ArjenKorevaar force-pushed the feature/LibmanAnalyzer branch from 132ade3 to 2c951b5 Compare April 15, 2023 09:14
@ArjenKorevaar
Copy link
Copy Markdown
Contributor Author

Rebased onto jeremylong:main

@jeremylong jeremylong added this to the 8.2.2 milestone Apr 19, 2023
Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit 55085e8 into dependency-check:main Apr 19, 2023
@jeremylong
Copy link
Copy Markdown
Collaborator

Thanks for the PR!

@ArjenKorevaar ArjenKorevaar deleted the feature/LibmanAnalyzer branch April 19, 2023 12:46
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ant changes to ant core changes to core documentation site documentation maven changes to the maven plugin tests test cases utils changes to utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants