fix: ArchiveAnalyzer should throw AnalysisException#5371
Merged
jeremylong merged 1 commit intomainfrom Jan 24, 2023
Merged
Conversation
- partially fixes #5357
aikebah
approved these changes
Jan 23, 2023
Collaborator
aikebah
left a comment
aikebah
left a comment
There was a problem hiding this comment.
LGTM... maybe also remove the now unused import of the ZipArchiveInputStream
Makes sense IMO to make the analyzer break on archives that cannot be properly extracted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #5357
Java's zip handling functions do not properly unzip mpk files. The errors may go un-noticed because the archive analyzer only printed a warning rather then throwing an analysis exception.
See https://issues.apache.org/jira/browse/COMPRESS-562
The updated code still fails for mpk files - but may work for apk files.