fix: reduce log size#5350
Merged
jeremylong merged 1 commit intomainfrom Jan 21, 2023
Merged
Conversation
Replace debug logging with trace logging for least necassary log statements that generate a ton of log messages
aikebah
approved these changes
Jan 20, 2023
Collaborator
aikebah
left a comment
aikebah
left a comment
There was a problem hiding this comment.
Makes sense to set these to trace... but makes me wondering... do we have a way to still trigger trace logging should we need the detailed info in future? (If not.... I'd say we would need a separate enhancement ticket to add such a flag, but this should still move forward to make the debug logs more manageable in size)
Collaborator
Author
|
I figured most of the time we would need these items we would be testing locally... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace debug logging with trace logging for least necessary log statements that generate a ton of log messages.