fix: Add double quote for "properties.security-severity" to fix processing of SARIF file in GitHub#5345
Merged
aikebah merged 1 commit intodependency-check:mainfrom Jan 18, 2023
Merged
Conversation
…ssing of SARIF file in GitHub
aikebah
approved these changes
Jan 18, 2023
Collaborator
aikebah
left a comment
aikebah
left a comment
There was a problem hiding this comment.
Thanks for having the PR in before I could start working on it
Collaborator
|
To bad it got noticed by you after @jeremylong already had been working hard to get 8.0.1 out, it will have to go into the next patch release |
Contributor
Author
|
I also had the stackoverflow problems, that's why I could only test 8.0.1. Sorry for the inconvenience and thanks for merging. 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
I'm so sorry. I somehow forgot the quotation marks in my PR here jeremylong/DependencyCheck#5227
I don't know how that could have happened. This causes the following exception in github processing:
This PR adds the quotation marks.