Skip to content

fix: Upgrade semver4j to 4.1.1 to prevent NullPointerException#5190

Merged
jeremylong merged 2 commits intomainfrom
5158-upgrade-semver4j
Dec 29, 2022
Merged

fix: Upgrade semver4j to 4.1.1 to prevent NullPointerException#5190
jeremylong merged 2 commits intomainfrom
5158-upgrade-semver4j

Conversation

@nhumblot
Copy link
Copy Markdown
Collaborator

@nhumblot nhumblot commented Dec 29, 2022

Fixes Issue

Fix #5158

Description of Change

This PR fix an issue in semver4j causing a NullPointerException by upgrading it to the latest version

Have test cases been added to cover the new functionality?

no

@nhumblot nhumblot changed the title #5158 Upgrade semver4j to 4.1.1 to handle trailing whitespaces and pr… #5158 Upgrade semver4j to 4.1.1 to prevent NullPointerException Dec 29, 2022
@nhumblot nhumblot force-pushed the 5158-upgrade-semver4j branch from 28269a3 to 6814ae1 Compare December 29, 2022 09:17
@nhumblot nhumblot changed the title #5158 Upgrade semver4j to 4.1.1 to prevent NullPointerException fix: Upgrade semver4j to 4.1.1 to prevent NullPointerException Dec 29, 2022
@nhumblot nhumblot requested a review from jeremylong December 29, 2022 09:27
@boring-cyborg boring-cyborg Bot added core changes to core tests test cases labels Dec 29, 2022
@jeremylong jeremylong added this to the 7.4.3 milestone Dec 29, 2022
@jeremylong
Copy link
Copy Markdown
Collaborator

Should have added the test case on this earlier... Thanks for the PR - I'll release this fix shortly.

@jeremylong jeremylong merged commit e2d1389 into main Dec 29, 2022
@jeremylong jeremylong deleted the 5158-upgrade-semver4j branch December 29, 2022 10:05
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core tests test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException in Semver for alternative NPM versions

2 participants