fix: resolve reported issues with npm#5135
Merged
jeremylong merged 4 commits intomainfrom Dec 13, 2022
Merged
Conversation
aikebah
approved these changes
Dec 11, 2022
Collaborator
aikebah
left a comment
aikebah
left a comment
There was a problem hiding this comment.
LGTM... maybe honor checkstyle's review and rename the variable to modulesRoot.... but current name is fine as well I would say.
|
Hi @jeremylong , I noted that this is planned for the release on the milestone If you don't mind, I would like to ask about the expected delivery of the fixes, as we are currently using this tool to scan npm packages, which has been broken since 7.4.0. We are still tracking the closed issues, because we wish to apply the latest tool version before closing our task. If it will take some time, we might want to create another task. Thanks for your understanding. Thank you for creating such a nice tool. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5128 and #5116