Exclude node_modules from Maven's scan path#4974
Merged
jeremylong merged 1 commit intomainfrom Oct 22, 2022
Merged
Conversation
…a scan of yarn.lock
aikebah
approved these changes
Oct 21, 2022
Collaborator
aikebah
left a comment
aikebah
left a comment
There was a problem hiding this comment.
I share your analysis that it would solve the issue and is an appropriate exclude for maven projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #4972
99% positive the error reported in #4972 is due to how file sets work with Maven. Other places in the code we filter out scanning the node_modules directory - filtering here should prevent the reported error regarding yarn.