Added local node_module check for NodePackageAnalyzer#4753
Merged
jeremylong merged 3 commits intodependency-check:mainfrom Aug 19, 2022
yarisvt:main
Merged
Added local node_module check for NodePackageAnalyzer#4753jeremylong merged 3 commits intodependency-check:mainfrom yarisvt:main
jeremylong merged 3 commits intodependency-check:mainfrom
yarisvt:main
Conversation
Collaborator
|
Do you have an example where |
Contributor
Author
|
I am using vaadin to build a web app and it automatically generates js files in the According to the npm docs, local paths can use four forms: |
jeremylong
reviewed
Aug 18, 2022
jeremylong
approved these changes
Aug 18, 2022
Collaborator
|
Thanks for the detailed response! I made one very minor change to the regex (s/*/{0,2}/). |
Contributor
Author
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes Issue #4752
Description of Change
Ignore packages that start with "./", since those are local packages
Have test cases been added to cover the new functionality?
no