Log when non-base suppressions rules are unused#4687
Closed
jeremylong wants to merge 1 commit intomainfrom
Closed
Conversation
aikebah
reviewed
Jul 24, 2022
| rules.forEach((rule) -> rule.process(dependency)); | ||
| rules.forEach((rule) -> { | ||
| rule.process(dependency); | ||
| if (!rule.isMatched() && !rule.isBase()) { |
Collaborator
There was a problem hiding this comment.
Checking for non-usage should be a post-processing activity, as many rules used in a full analysis will not be hit for a specific dependency (as they apply to a different dependency).
Collaborator
Author
There was a problem hiding this comment.
Thank you. I completely forgot that these could run several times. I'll update this shortly.
Collaborator
Author
|
superseded by #4709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4685
This might be useful to some - a log message has been added when a non-base suppression rule was not used.