Work-around for MSHARED-998 until it's resolved and we can upgrade to a newer transfer-utils#3702
Merged
jeremylong merged 5 commits intomainfrom Oct 6, 2021
Merged
Work-around for MSHARED-998 until it's resolved and we can upgrade to a newer transfer-utils#3702jeremylong merged 5 commits intomainfrom
jeremylong merged 5 commits intomainfrom
Conversation
…en the artifact cannot be resolved
jeremylong
approved these changes
Oct 6, 2021
Collaborator
jeremylong
left a comment
jeremylong
left a comment
There was a problem hiding this comment.
I was thinking we would have to use both resolution mechanisms until the upstream bug is resolved. PR looks good - thanks!
Collaborator
|
I will try and release this on Friday morning - unfortunately, I can't release before then due to other time commitments (and the next release will also require some updates on the homebrew side) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #3679
Description of Change
As a temporary work-around do not apply a filter to artifact-resolution when resolving for a DependencyNode that uses a
<classifier>which would lead to a NullPointerException deep down in maven's internal logic.Have test cases been added to cover the new functionality?
yes, an integration testcase has been added that triggers the error with the old codebase and succeeds with the workaround.