Matching Strategy - Product Names & Major Version Numbers#3207
Merged
jeremylong merged 1 commit intomainfrom Mar 21, 2021
Merged
Matching Strategy - Product Names & Major Version Numbers#3207jeremylong merged 1 commit intomainfrom
jeremylong merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #3193 and #3183
With 6.1.2 a new matching strategy was introduced that slowed down dependency-check. This PR removes the original implementation and improves the existing matching strategy to account for the fact that CPE product names may include the major version number.