Skip to content

Implementation of the new database schema for Oracle database#2899

Merged
jeremylong merged 8 commits intodependency-check:mainfrom
aikebah:issue-2755
Oct 19, 2020
Merged

Implementation of the new database schema for Oracle database#2899
jeremylong merged 8 commits intodependency-check:mainfrom
aikebah:issue-2755

Conversation

@aikebah
Copy link
Copy Markdown
Collaborator

@aikebah aikebah commented Oct 18, 2020

Fixes Issue #2755

Description of Change

Updated the Oracle initialization script and custom queries to match up with the new database layout of v6

Optimized querying Oracle by making larger fetches than by default to more closely match the other DBMSes that fetch ALL results directly into the ResultSet.

Have test cases been added to cover the new functionality?

No, not feasible as there is no Oracle DB to run the testcases against.
Some manual tests run with various projects to compare the vulnerabilities output between them and a manual comparison of post-initial load counts for all tables between PostgreSQL and Oracle to make sure both import the same number of records for each.

@boring-cyborg boring-cyborg Bot added the core changes to core label Oct 18, 2020
@jeremylong jeremylong added this to the 6.0.3 milestone Oct 19, 2020
@jeremylong jeremylong merged commit 666d669 into dependency-check:main Oct 19, 2020
@jeremylong
Copy link
Copy Markdown
Collaborator

@aikebah thank you for the PR!

@aikebah aikebah deleted the issue-2755 branch October 19, 2020 16:06
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core changes to core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants