Skip to content

Support transitioning Ruby git sources to Rubygems releases#84

Merged
greysteil merged 8 commits into
masterfrom
git-commit-checker
Sep 29, 2017
Merged

Support transitioning Ruby git sources to Rubygems releases#84
greysteil merged 8 commits into
masterfrom
git-commit-checker

Conversation

@greysteil

@greysteil greysteil commented Sep 26, 2017

Copy link
Copy Markdown
Contributor

Idea is to generate diffs as follows when the reference a git commit is pinned to is included in a release:

- gem "pry", git: "https://github.com/pry/pry", ref: "b12a7da"
+ gem "pry", "= 0.11.0"

Closes dependabot/feedback#23.

TODO:

  • Create GitCommitChecker class that can tell whether a commit is included in a release
  • Use new GitCommitChecker class to generate correct requirements in UpdateChecker
  • Spec everything works in FileUpdater (it won't but can be fixed)
  • Spec everything works in MetadataFinder (it should...)
  • Update PullRequestCreator to explain what's happening for PRs like these
  • Double-check that UpdateChecker will only switch to released version when appropriate

@greysteil greysteil force-pushed the git-commit-checker branch 3 times, most recently from e072a4c to e338eb7 Compare September 27, 2017 00:06
@greysteil greysteil force-pushed the git-commit-checker branch 6 times, most recently from c0a86a7 to 24bad49 Compare September 28, 2017 09:40
@Floppy

Floppy commented Sep 29, 2017

Copy link
Copy Markdown

Oooh, this would be lovely

@greysteil greysteil merged commit c33b77c into master Sep 29, 2017
@greysteil greysteil deleted the git-commit-checker branch September 29, 2017 14:34
@greysteil greysteil changed the title [WIP] Support transitioning Ruby git sources to Rubygems releases Support transitioning Ruby git sources to Rubygems releases Sep 29, 2017
@greysteil

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maven Wrapper Feature Suggestion

2 participants