Revert "test(node/http): modify writable of ClientRequest (#2945)"#2950
Merged
cjihrig merged 1 commit intodenoland:mainfrom Nov 28, 2022
cjihrig:revert
Merged
Revert "test(node/http): modify writable of ClientRequest (#2945)"#2950cjihrig merged 1 commit intodenoland:mainfrom cjihrig:revert
cjihrig merged 1 commit intodenoland:mainfrom
cjihrig:revert
Conversation
This reverts commit 5f5413d. This change was made in response to denoland/deno#16616. However, that change was reverted in denoland/deno#16839 due to it breaking Vite. Let's revert it here as well.
Contributor
|
A bit of a bummer because that fix in theory was quite nice. This revert LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 5f5413d.
This change was made in response to denoland/deno#16616. However, that change was reverted in denoland/deno#16839 due to it breaking Vite. Let's revert it here as well.