Skip to content

Node compat test suite is failing on Windows #2807

Description

@cjihrig

Describe the bug

Starting with 820474d, the Windows CI has been failing consistently with the errors below. Nothing jumps out on the std side, so I'm thinking maybe it could be a change in core causing the failures here.

Node.js compatibility "parallel\test-net-allow-half-open.js" => ./node/_tools/test.ts:46:8
error: AssertionError: Failed assertion: error: Uncaught Error: read ECONNRESET
    Error.captureStackTrace(err);
          ^
    at __node_internal_captureLargerStackTrace (file:///C:/a/deno_std/deno_std/node/internal/errors.ts:113:11)
error: Test failed
    at __node_internal_errnoException (file:///C:/a/deno_std/deno_std/node/internal/errors.ts:194:10)
    at TCP.onStreamRead [as onread] (file:///C:/a/deno_std/deno_std/node/internal/stream_base_commons.ts:279:20)
    at TCP.#read (file:///C:/a/deno_std/deno_std/node/internal_binding/stream_wrap.ts:298:12)

    throw new AssertionError(msg);
          ^
    at assert (file:///C:/a/deno_std/deno_std/testing/asserts.ts:139:11)
    at fail (file:///C:/a/deno_std/deno_std/testing/asserts.ts:582:3)
    at fn (file:///C:/a/deno_std/deno_std/node/_tools/test.ts:92:9)

Node.js compatibility "parallel\test-net-socket-close-after-end.js" => ./node/_tools/test.ts:46:8
error: AssertionError: Failed assertion: error: Uncaught AssertionError
    Error.captureStackTrace(this, stackStartFn || stackStartFunction);
          ^
    at new AssertionError (file:///C:/a/deno_std/deno_std/node/assertion_error.ts:532:11)
    at toNode (file:///C:/a/deno_std/deno_std/node/assert.ts:77:15)
    at assert (file:///C:/a/deno_std/deno_std/node/assert.ts:95:3)
    at Socket.<anonymous> (file:///C:/a/deno_std/deno_std/node/_tools/test/parallel/test-net-socket-close-after-end.js:28:5)
    at Socket.emit (file:///C:/a/deno_std/deno_std/node/_events.mjs:379:28)
    at file:///C:/a/deno_std/deno_std/node/net.ts:1424:14
    at deno:core/01_core.js:236:9

    throw new AssertionError(msg);
          ^
    at assert (file:///C:/a/deno_std/deno_std/testing/asserts.ts:139:11)
    at fail (file:///C:/a/deno_std/deno_std/testing/asserts.ts:582:3)
    at fn (file:///C:/a/deno_std/deno_std/node/_tools/test.ts:92:9)

 FAILURES 

Node.js compatibility "parallel\test-net-allow-half-open.js" => ./node/_tools/test.ts:46:8
Node.js compatibility "parallel\test-net-socket-close-after-end.js" => ./node/_tools/test.ts:46:8

Environment
CI. I don't have a Windows setup to test locally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions