Fix travis#4
Merged
Merged
Conversation
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
It used to be that the realm/context created with the isolate was sometimes called "global context" and sometimes "main context/realm". This goes back to the days before JsRealm, when the JsRuntime::global_context method returned a v8::Global for the only v8::Context that existed in the isolate. Nowadays that is no longer the case, and we should call it the main realm. That change by itself would also rename some properties/variables from is_global to is_main, which is also used elsewhere to refer to the top-level JsRuntime/isolate in a process. Therefore, the names are changed to is_main_runtime and is_main_realm to disambiguate.
losfair
pushed a commit
that referenced
this pull request
Aug 14, 2024
ry
pushed a commit
that referenced
this pull request
Mar 24, 2025
qti3e
pushed a commit
that referenced
this pull request
Apr 4, 2025
4 tasks
bartlomieju
added a commit
that referenced
this pull request
Jul 9, 2026
- extract_tarball_gz: skip symlink/hardlink tar entries (path-traversal via a symlink to an outside dir + a file nested under it, on arbitrary registry/@jsr content). - Rebase the user's compilerOptions.paths + baseUrl onto .deno/ (the generated tsconfig lives one level down); they were copied verbatim, so `~/*`->`./src/*` resolved to .deno/src/* and broke every import through a user alias. Dropped paths/baseUrl from passthrough; added rebase_onto_deno_dir + test. - sync_types_command: check node_modules/.deno components on the path RELATIVE to the project root, so an ancestor dir named node_modules/.deno no longer filters every root away (empty graph, no error). - ensure_root_tsconfig: edit the existing tsconfig by byte-range splice via the jsonc AST instead of re-serializing, preserving the user's comments and formatting (previously silently stripped on the first sync). - strip_top_level_type_decls: bound the leading-comment back-pop to contiguous comment lines (an unbounded 'pop until /**' could delete earlier decls), and make the type-alias skip track bracket depth so an interior ';' doesn't end it early. Deferred (noted on the PR): resolution flags incl --allow-import (#3), skipped-remote policy (#4), import-map scopes (#8), @types/node via #35889 (#10).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.