core: factor out EsIsolate from Isolate#3613
Merged
Merged
Conversation
ry
reviewed
Jan 6, 2020
|
|
||
| pending_dyn_imports: FuturesUnordered<StreamFuture<IntoStream<DynImport>>>, | ||
| dyn_import: Option<Arc<DynImportFn>>, | ||
| waker: AtomicWaker, |
Member
There was a problem hiding this comment.
Was AtomicWaker already part of deno_core::Isolate?
Member
Author
There was a problem hiding this comment.
Yes, it's used in two situations:
a) more ops to poll
b) more dyn imports to poll
Member
There was a problem hiding this comment.
This doesn't need to be addressed now but feel like we should avoid tying deno_core to tokio. The AtomicWaker feels like it's unnecessarily growing the abstraction layer of deno_core.
Member
Author
There was a problem hiding this comment.
AtomicWaker is part of futures crate
ry
reviewed
Jan 6, 2020
ry
reviewed
Jan 6, 2020
ry
reviewed
Jan 6, 2020
Member
Author
|
@ry I'm not sure about the name though 🤔 |
Member
|
@bartlomieju EsIsolate? I think it's ok. |
Member
Author
Alright 👍 |
95th
reviewed
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR factors out all module related stuff from
Isolateto newEsIsolate.Next step would be to refactor
core/modules.rsby merging it's structs withEsIsolate